Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve brimcap error handling #2955

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Improve brimcap error handling #2955

merged 10 commits into from
Jan 23, 2024

Conversation

nwt
Copy link
Member

@nwt nwt commented Jan 7, 2024 •
edited by philrz
Loading

Zui displays a Node exception if brimcap exits without reading its standard input to EOF. Display an error toast with details instead.

Update, here's how the branch looks now.

brimcap_error.mp4

Closes #2926

@nwt
Improve brimcap error handling
73fcbff 
Zui displays a Node exception if brimcap exits without reading its
standard input to EOF.  Display an error toast with details instead.
@nwt nwt requested a review from jameskerr January 7, 2024 01:39
@philrz
Copy link
Contributor

philrz commented Jan 7, 2024

I tested out the branch with the pcap from #2926 (comment). The error presentation is improved enough that I'd consider this a fix for #2926.

image

@jameskerr jameskerr requested a review from philrz January 22, 2024 18:14
@philrz

This comment was marked as resolved.

Sign in to view
@philrz
Copy link
Contributor

philrz commented Jan 22, 2024

@jameskerr: The e2e test looks good. FYI, I made a temporary branch based on this branch to which I merged main so I could have the knobs available in my improved e2e.yml. With that I did this Actions run that shows your e2e test running reliably on all OSes in CI.

At this point I think I'm good with this one merging, but since @nwt was already involved in this code and I know the Zui/Brimcap error channel has some complexities, I'd feel better if he had a chance to give it a 👍 first. I guess since he opened the PR he technically can't be the one to click "Approve" but I'll wait for him to give the word somewhere and then I'll do the clicking.

philrz
philrz approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwt and I talked offline and he didn't feel he had more to add to the review, so I'm hereby giving it the 👍.

@jameskerr jameskerr merged commit a5ee8af into main Jan 23, 2024
3 checks passed
@jameskerr jameskerr deleted the improve-brimcap-errors branch January 23, 2024 19:31
@philrz philrz linked an issue Jan 23, 2024 that may be closed by this pull request
"Error: write EPIPE" or "Error: write EPIPE" on attempted pcap import #2926
Closed
This was referenced Jan 23, 2024
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrz philrz philrz approved these changes

@jameskerr jameskerr Awaiting requested review from jameskerr

Assignees

@nwt nwt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Error: write EPIPE" or "Error: write EPIPE" on attempted pcap import
3 participants
@nwt @philrz @jameskerr